Deleting a Skin While in the Skin Editor Causes Default Skin To Copy

ppy / osu

rhythm is just a *click* away!

https://osu.ppy.sh

MIT License

14.63k stars 2.16k forks source link

Deleting a Skin While in the Skin Editor Causes Default Skin To Copy #28446

Open mojobojo opened 2 weeks ago

mojobojo commented 2 weeks ago

Type

Other

Bug description

While you are in the skin editor and delete the skin you are currently using, it creates a copy of the default skin. I just discovered this after deleting some skins.

Edit: They seemed to have disappeared after I closed the editor. Edit2: I continued to delete skins one at a time, and these skin copies came back.

Screenshots or videos

Edit3: I went under maintence and deleted all the skins and it somehow made another copy.

Version

Lazer 2024.521.2

Logs

1718101554.runtime.log

bdach commented 2 weeks ago

This is semi-intentional because otherwise you would be able to edit the default skin which is not allowed.

The alternative would be to close skin editor when the current skin is deleted. I'm not sure we want that.

mojobojo commented 2 weeks ago

This is semi-intentional because otherwise you would be able to edit the default skin which is not allowed.

The alternative would be to close skin editor when the current skin is deleted. I'm not sure we want that.

I get what you mean, this behavior continued after I exited the editor and deleted skins one by one, then decided to try to just delete all skins in the maintenance tab. Even after deleting all skins, it made a new copy, despite not being in the editor. I finally got all skins to clear by choosing a default skin, restarting the game client, then deleting all skins.

bdach commented 2 weeks ago

this behavior continued after I exited the editor and deleted skins one by one, then decided to try to just delete all skins in the maintenance tab. Even after deleting all skins, it made a new copy, despite not being in the editor

I can't reproduce this. As far as I can tell in my testing over here, after closing the skin editor skins delete correctly without creating copies. Looking at the code that should not be happening either.

Can you show a video of this or something?

mojobojo commented 2 weeks ago

this behavior continued after I exited the editor and deleted skins one by one, then decided to try to just delete all skins in the maintenance tab. Even after deleting all skins, it made a new copy, despite not being in the editor

I can't reproduce this. As far as I can tell in my testing over here, after closing the skin editor skins delete correctly without creating copies. Looking at the code that should not be happening either.

Can you show a video of this or something?

I am trying to reproduce it myself with no luck at the moment. I don't know the exact order of things I did to make it do this but I will let you know if I get it to happen again. I was exporting, editing, importing, deleting a lot of skins so anything could have happened between all of that.