search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
14.64k stars 2.16k forks source link

Use more descriptive HitObject names for debugger displays #28465

Closed smoogipoo closed 2 weeks ago

bdach commented 2 weeks ago

I was going to object to ToString() usage and instead suggest something that uses [DebuggerDisplay] instead or something but alas.

smoogipoo commented 2 weeks ago

I mostly intended this for the draw visualiser, which doesn't use DebuggerDisplay (yet?) :(

bdach commented 2 weeks ago

which doesn't use DebuggerDisplay (yet?)

Given that DebuggerDisplayAttribute supports arbitrary expressions it's probably never.

Anyways I can live with this probably, just hoping nobody actually depended on the previous .ToString() output...