search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.37k stars 2.29k forks source link

Changing mode after playing osu!mania with nonstandard number of keys crashes game #2847

Closed ticotaco72 closed 6 years ago

ticotaco72 commented 6 years ago

Played osu!mania with different number of keys, and changed mode to osu!. Game freezed for few seconds and crashed.

It does the same with other game modes.

logs: performance-gamethread.draw.log performance-gamethread.input.log performance-gamethread.update.log runtime.log database.log network.log performance.log performance-gamethread.audio.log

Playing on win 10 if it changes anything.

peppy commented 6 years ago

This looks like a pretty serious oversight in bindables

ticotaco72 commented 6 years ago

Problem still exists for me ( i have updated my client) logs: database.log network.log performance.log performance-gamethread.audio.log performance-gamethread.draw.log performance-gamethread.input.log performance-gamethread.update.log runtime.log

ticotaco72 commented 6 years ago

01.07.2018 21:46:35: fatal error: 01.07.2018 21:46:35: System.InvalidCastException: Nie można rzutować obiektu typu 'osu.Game.Rulesets.Osu.Beatmaps.OsuBeatmapConverter' na typ 'osu.Game.Rulesets.Mania.Beatmaps.ManiaBeatmapConverter'. 01.07.2018 21:46:35: w osu.Game.Rulesets.Mania.Mods.ManiaKeyMod.ApplyToBeatmapConverter(IBeatmapConverter beatmapConverter) 01.07.2018 21:46:35: w osu.Game.Beatmaps.WorkingBeatmap.GetPlayableBeatmap(RulesetInfo ruleset) 01.07.2018 21:46:35: w osu.Game.Screens.Select.BeatmapInfoWedge.BufferedWedgeInfo.getInfoLabels() 01.07.2018 21:46:35: w osu.Game.Screens.Select.BeatmapInfoWedge.BufferedWedgeInfo.load(LocalisationEngine localisation) 01.07.2018 21:46:35: 01.07.2018 21:46:35:

"cannot put 'osu.Game.Rulesets.Osu.Beatmaps.OsuBeatmapConverter' on 'osu.Game.Rulesets.Mania.Beatmaps.ManiaBeatmapConverter'." 18-19 line of runtime.log

smoogipoo commented 6 years ago

There hasn't been a new release yet, please wait.

peppy commented 6 years ago

Can you take a video of how you are still making this fail? I can't seem to locally.

ticotaco72 commented 6 years ago

database.log network.log performance.log performance-gamethread.audio.log performance-gamethread.draw.log performance-gamethread.input.log performance-gamethread.update.log runtime.log

version 2018.701.0

does the same with 2018.702.0

https://drive.google.com/open?id=12IR6fxKaU_RcknbySGQke7bo4o-vrMoQ

ticotaco72 commented 6 years ago

after deselecting all mods problem disappears

ticotaco72 commented 6 years ago

maybe it is connected with thing that only mania have usable mods that aren't in other modes just deselect mods not possible to open in for example osu! when changing mode, same in future with autopilot relax, target and spun out

peppy commented 6 years ago

Have reproduced a lingering issue and am working on a fix.

Lolihunter1337 commented 6 years ago

is #2788 related to it?

peppy commented 6 years ago

Yes, looks like a duplicate.