ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
14.64k stars 2.16k forks source link

Implement toggling visibility of pass and fail storyboard layers #28480

Closed bdach closed 2 weeks ago

bdach commented 2 weeks ago

Closes https://github.com/ppy/osu/issues/6842.

https://github.com/ppy/osu/assets/20418176/4ac1b403-d054-4047-98b7-6d2d48a14ded

This is a rather barebones implementation, just to get this in place somehow at least. The logic is simple - 50% health or above shows pass layer, anything below shows fail layer.

This does not match stable logic all across the board because I have no idea how to package that. Stable defines "passing" in like fifty ways:

The biggest issues of these are probably the first two, and they can probably be fixed, but would require a new member on Ruleset and I'm not sure how to make one look, so I'm not doing that at this time pending collection of ideas on how to do that.