search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
14.64k stars 2.16k forks source link

Disable the automatic offset adjustment button if the offset of the previous play was 0 #28481

Closed shiumano closed 2 weeks ago

shiumano commented 2 weeks ago

I luckily found this bug when I retried with an offset of 0. It is almost impossible to reproduce outside of a test scene, but I guarantee it was there once. I have disabled the button in the event, but if there is no change after adjusting it, it does not work. It is strange when the button is enabled when no offset adjustment is needed in the first place, so we made sure to check it first.

master this PR
recording.webm recording (1).webm
bdach commented 2 weeks ago

I luckily found this bug

What "bug"?

This may be aesthetic / UX at best, but surely there's no bug here? What harm could the button cause if offset of the last play was 0?

shiumano commented 2 weeks ago

Yes, it is somewhat uncomfortable but does not cause serious problems. Still, I think the expected behavior is that the button will be enabled if it needs to be adjusted, and disabled if it has been adjusted. I will edit the wording if it needs to be changed.