ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
14.64k stars 2.16k forks source link

when data folder becomes accessible, the configs are gone #28487

Open sigasigasiga opened 2 weeks ago

sigasigasiga commented 2 weeks ago

Type

Game behaviour

Bug description

  1. go to settings, click "change folder location", pick a folder on a removable hard drive
  2. close the game
  3. remove the hard drive
  4. open the game, osu storage error is shown
  5. attach the hard drive
  6. click "try again" on the error screen
  7. BUG: all the configs are gone

Screenshots or videos

Screenshot 2024-06-14 232308

Version

2024.521.2

Logs

compressed-logs.zip

sigasigasiga commented 2 weeks ago

maybe related to #26027

bdach commented 2 weeks ago

What does "all the configs" mean in this context?

sigasigasiga commented 2 weeks ago

@bdach

  1. login info
  2. user settings
  3. beatmap settings ("ignore beatmap skin", "background dim", etc)

and maybe something else that i haven't noticed

smoogipoo commented 2 weeks ago

I don't think that "Try again" button can ever work in its current state without a game restart. There would need to be some series of callbacks to refresh the various config managers, available rulesets, realm database, etc.

bdach commented 2 weeks ago

Maybe we should force one then?

peppy commented 2 weeks ago

It's a bit unfortunate considering how close it is to working, but I'm fine with forcing one for now, as long as there's an attached comment explaining what is required to make it not require the restart.