Open shiumano opened 3 months ago
shiumano
commented
3 months ago https://github.com/ppy/osu/discussions/16732
I mean, this is what I wanted to create. If you add "unlimited stacking" you can really experience AR -∞, but it will run incredibly slow
bdach
commented
3 months ago If you add "unlimited stacking" you can really experience AR0, but it will run incredibly slow
I mean... yeah? If you read the discussion thread you linked you'll get a detailed breakdown why it is slow and what would be required to implement that properly?
Not sure what to do with this PR at all. I have no idea what "linear stacking" is supposed to mean so I'm not sure how users are going to know.
shiumano
commented
3 months ago I mean... yeah? If you read the discussion thread you linked you'll get a detailed breakdown why it is slow and what would be required to implement that properly?
It is. This is premature and should not be done yet. (Although putting a FreezeFrame on a tremendously long combo will make it tremendously heavy, but that's not the same thing.)
Not sure what to do with this PR at all. I have no idea what "linear stacking" is supposed to mean so I'm not sure how users are going to know.
The main cause of the problem is my poor English. Sorry. I have tried to illustrate this in case you are interested. If I can't make you understand this, I can't do it anymore.
”Linear Staking” ON:
”Linear Stacking” OFF:
bdach
commented
3 months ago Well looking at that explanation I'd say that "on" is the only behaviour that makes sense to me and that it should be the only available option.
shiumano
commented
3 months ago I understand. I will delete it.
I came up with the idea and implemented it. Adjust the amount of combos displayed at the same time. Increasing the amount displayed will have an AR0-like effect.
https://github.com/ppy/osu/assets/75152752/8e31ba55-c5ff-464a-9634-bd0367e4c66a
However, I think there are many problems with the current code.
lastNewCombo) is not in line with the current situation