search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
14.64k stars 2.16k forks source link

Change editor speed adjustment back to adjusting tempo #28521

Open bdach opened 2 weeks ago

bdach commented 2 weeks ago

The important distinction here is that to prevent misuse when timing, the control will revert to 1.0x speed and disable when moving to timing screen, with a tooltip explaining why.

https://github.com/ppy/osu/assets/20418176/1aa8c616-8e73-4dee-a293-1820716a665e

OliBomby commented 2 weeks ago

Is timing at lower speeds accurate if it did only change audio frequency? Maybe we can enable the playback speed in the timing screen if it adjusts frequency instead of tempo there.

bdach commented 2 weeks ago

Is timing at lower speeds accurate if it did only change audio frequency?

There are have been concerns brought up before like https://github.com/ppy/osu/discussions/27826 or https://github.com/ppy/osu/discussions/26421 which tend to suggest that it might not be. I'm somewhat open to having it stay as a frequency adjustment if those are considered minor.

Hiviexd commented 2 weeks ago

if it's concluded that timing stays (mostly) accurate with the frequency change then we can definitely have the best of both worlds by keeping the tempo change for compose page (to better identify snaps/rhythms in the song), and having the frequency change in the timing page.