Closed bdach closed 1 week ago
I hope this is the right place for me to post this, but I'd like to add some info about why some mappers dislike the hit markers. The main thing is that hit markers growing in size makes it difficult to tell how far apart objects are when they are packed closely.
Objects placed like this:
RFC.
master:
https://github.com/ppy/osu/assets/20418176/c74c55e2-4cfa-4ad4-bac5-2e39d337e183
this PR:
https://github.com/ppy/osu/assets/20418176/14e9d2de-b017-4401-85fd-1be25766760f
Let me be clear: is the code in this pull usually something I'd close in 2 seconds with the comment of "we don't do changes in DHOs just for the editor"? Yes it is. So why am I opening this? Because users claim that the current state of this toggle is unusable and that I "don't care about preserving backwards compatibility" which just pissed me off hard enough into writing this accursed diff. I just don't want to read anyone saying that again if it can be avoided.
Not adding tests until I'm sure this survives at least 5 seconds of review. I'd like to think that this is reasonably contained so that there's a chance of that happening but we'll see.