ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
14.64k stars 2.16k forks source link

Taiko Constant Speed mod can change base scroll speed for map #28566

Open JamieWright99 opened 4 days ago

JamieWright99 commented 4 days ago

Type

Game behaviour

Bug description

I found a few Taiko songs where enabling Constant Speed will make the scroll speed faster, even though the maps use 1x SV value throughout the map. Here's some ones I found:

https://osu.ppy.sh/beatmapsets/31061#taiko/102998 https://osu.ppy.sh/beatmapsets/29226#taiko/99153 https://osu.ppy.sh/beatmapsets/28063#taiko/112935

The video shows what I mean, bottom has Constant Speed enabled.

Screenshots or videos

https://github.com/ppy/osu/assets/102170503/f4d7a778-f100-4ed0-93db-4cde7b8df310

Version

2024.625.0-lazer

Logs

compressed-logs.zip

smoogipoo commented 3 days ago

Isn't this intentional, because constant speed is otherwise too slow?

https://github.com/ppy/osu/blob/3d6a9ccb6d8e2ed270ca45a97ed5a0fa18e9781f/osu.Game.Rulesets.Taiko/UI/DrawableTaikoRuleset.cs#L85-L90

Maybe we should instead use something like the most common scroll speed?

bdach commented 3 days ago

@Hiviexd maybe you can provide some insight here

smoogipoo commented 3 days ago

Well, the actual multiplier itself was added by me and @peppy in https://github.com/ppy/osu/pull/24550 . The implementation above only moved it to a more base level. But I remember there being maps that were indeed "sluggish" with constant mod, hence the multiplier.

bdach commented 3 days ago

Well, the actual multiplier itself was added by me and @peppy in #24550

I'm aware, but if it was fine to move it to a more base level, then I'd assume it was fine from a playability angle when writing the mod.

XeZey commented 3 days ago

Im not sure what is meant by "sluggish". It is true that especially on lower bpm maps, the scrolling is rather slow, (due to 1/4 spacing being the way it is) but this is kind of just part of how taiko scrolling works. Mappers will intentionally adjust scroll speed to be higher on low bpm maps for more difficult maps, especially if the map is really dense despite low bpm (constant usage of 1/8 patterns for example). However, as a default, having a difference in scrolling speed across beatmaps for readability sake seems really weird. Taiko players are used to having "spacing" and not "speed" be a main factor for readability. Even if a map was 50 bpm, as long as the map only uses 1/4 spacing and doesnt try to do some weird 1/16 in order to map quasi 200bpm patterns, that scroll speed would be perfectly readable for taiko players and it would not feel off at all. imo its better to leave this as is and just remove the scroll speed adjustment (or even remove the mod alltogether and add this as an option under difficulty adjust)

there is also an interesting idea here for the mod where you could add an option that implements bpm-independant scroll speed, similar to mania, which would fit really well with the name and also kind of gets at what was attempted here but i dont know if this is the right place to mention.