ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
14.64k stars 2.16k forks source link

Fix crashes when opening scale/rotation popovers during selection box operations #28589

Closed bdach closed 3 days ago

bdach commented 4 days ago

The rotation and scale handlers sort of assumed that they would not be interfered with by another operation, but they actually can be - e.g. try rotating a selection via the rotate handle and then pressing Ctrl-R. It'll die on an exception. This PR changes it so that doing the same doesn't open the rotate popover.

You could argue that the other thing that could be done is to commit the previous operation, but I kinda don't wanna go there because that will be messy to handle.

ppy-sentryintegration[bot] commented 3 days ago

Sentry issue: OSU-1CDT

ppy-sentryintegration[bot] commented 3 days ago

Sentry issue: OSU-1CEA