search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
14.64k stars 2.16k forks source link

Refactor out taiko Peaks skill #28596

Closed stanriders closed 3 days ago

stanriders commented 3 days ago

This change removes Peaks skill and moves all of the combined calculation into the taiko difficulty calculator. The idea is that having skills within skills isn't really a good design, especially since Peaks skill was calling processing manually instead of passing it through the main difficulty calculation abstractions, and also enables back osu-tools per-skill strain visualization since it assumes that skills will always be present in the DifficultyCalculator.Skills[] array

Actual difficulty/performance values shouldn't change and from my limited testing seems like values didn't change.

This also changes the way difficulty calculator fetch skills from hardcoded array indexing to skills.First(x=> x is RequiredSkill) which I'd want to change in all difficulty calculators eventually

smoogipoo commented 3 days ago

!diffcalc

RULESET=taiko

github-actions[bot] commented 3 days ago

Target: https://github.com/ppy/osu/pull/28596 Spreadsheet: https://docs.google.com/spreadsheets/d/1-JzfCBqhSzL_zQutZZsfryC_R_M7dOsJSme18LSvQ3U/edit