ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
14.64k stars 2.16k forks source link

modifying CS value to be lower makes bottom of border disappear #28604

Open Tyfaspo opened 3 days ago

Tyfaspo commented 3 days ago

Type

Cosmetic

Bug description

Using any mod that will make CS value higher will gradually move bottom part of border outside of the gameplay screen. This is more visible using lower gameplay scaling. Can be replicated with any skin I have.

Screenshots or videos

osu_2024-06-25_23-15-10 osu_2024-06-25_23-14-32

Version

2024.625.2-lazer

Logs

compressed-logs.zip

Tyfaspo commented 3 days ago

image CS3.8 -> 2.1 cuts off bottom part entirely

peppy commented 3 days ago

The border going off-screen is actually where it should be.

As for it disappearing, can you make this happen on the default skin?

Tyfaspo commented 3 days ago

image

On scale 85% using unmodified argon pro with CS7->2.8 It seems that it gets cut off only at lower values, starting around 3.1 At 2.7 lower side is gone completely

sidetrack question, i don't really like how new border acts, it gets in the way of ui elements of legacy skins, such as UR bar, maybe option in settings to pick expanding behaviour with its being a default?