ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
14.64k stars 2.16k forks source link

Fix intermittent failure in online menu banner tests #28605

Closed frenzibyte closed 3 days ago

frenzibyte commented 3 days ago

Noticed locally and on CI (https://github.com/ppy/osu/actions/runs/9638362199/job/26578941060?pr=28559). The image could take too long to load that the game becomes idle and the main menu screen returns to Initial state (as mentioned on discord and signified by this line). When the main menu is in Initial state, the online banner is hidden and will not receive updates, therefore not adding new images after they finish loading.