Rendering more than 1 slider in the editor causes heavy performance issues

ppy / osu

rhythm is just a *click* away!

https://osu.ppy.sh

MIT License

14.64k stars 2.16k forks source link

Rendering more than 1 slider in the editor causes heavy performance issues #28618

Closed piee-kun closed 2 days ago

piee-kun commented 3 days ago

Type

Performance

Bug description

During editing, when more than one slider is being rendered (usually around 3-4 can cause massive drops), the FPS drops heavily. As far as my testing went, this does not occur with circles, and it doesn't occur in gameplay. Both Vulkan and D3D11 experience this issue, however FPS on Vulkan is less affected, as the base framerate is higher.

Screenshots or videos

4 sliders rendered 5 circles rendered

Version

2024.625.2

Logs

compressed-logs.zip

Peter-io commented 3 days ago

Same here vs

Sliders really tank performance now

peppy commented 3 days ago

This is probably going to be from UpdateState being called (and now forcefully) every frame.

@bdach I think we'll just want to change the every-frame transforms to not be transforms as I touched on in the original PR. I don't think it will be hard to convert them to raw interpolations. Will take a look tomorrow unless you want to.