Closed peppy closed 6 days ago
This part should also be changed to get the maximum end time (i.e. Beatmap.GetLastObjectTime()
) instead of the last object's end time, right?
I cannot easily imagine a test case that warrants that to be applied though (I don't understand the logic quite well).
I don't understand the logic quite well
The check is supposed to remove manually-adjusted breaks which are placed after all objects so that they don't hang around.
This part should also be changed to get the maximum end time (i.e.
Beatmap.GetLastObjectTime()
) instead of the last object's end time, right?
In theory yes, in practice it probably doesn't matter because of two circumstances:
Due to the above I'm pretty sure it's not possible to manufacture a test case that exercises this. I'll add one for posterity at least but yeah.
Closes https://github.com/ppy/osu/issues/28622.