ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
14.64k stars 2.16k forks source link

Long hold "percy" note sprite endings placed incorrectly on screen #28673

Closed beeberies closed 2 days ago

beeberies commented 4 days ago

Type

Cosmetic

Bug description

Skins with the long "percy" hold note sprite have their sprite ending "earlier" than in stable. This makes it near-impossible to differentiate short hold notes from medium-length hold notes, as well as throwing off the release timings for mania players transitioning to lazer that use this as their long note sprite. This happens on both bojii(a top mania player)'s skin and my skin where I took the LN_BODY file (the 20,000 pixel long image) from bojii's skin and replaced it in my own. bojii's skin my skin

Screenshots or videos

NOTE: my skin has circles, bojii's has bars

in stable:

GHOST VIP: https://github.com/ppy/osu/assets/171388105/66e98383-ac03-4266-ab29-8dc82ee6a36b FULL FLAVOR ODON (downscroll): Screenshot 2024-06-29 035441

in lazer:

GHOST VIP: https://github.com/ppy/osu/assets/171388105/bdfd9b02-aa68-4ee0-ab09-8d142e7e7b5c FULL FLAVOR ODON (upscroll): Screenshot 2024-06-29 035255

Even with identical scroll speeds, there is some differences in where the LN sprite ends.

Also, with bojii's skin in FULL FLAVOR ODON, where the hold note fades much earlier (judging by the next yellow and blue notes), I believe the small vertical rectangle is displayed as the LN tail, which is shown noticeably earlier in lazer than in stable.

Version

2024.625.2-lazer

Logs

compressed-logs.zip

beeberies commented 4 days ago

Oh wait my bad, the vertical rectangle in bojiis skin is NOT the end of a hold note, oversight in my part.

However, I still notice a difference when comparing stable to lazer

smoogipoo commented 2 days ago

This is intentional for now. Support is only approximate but not exact as mentioned in the original PR https://github.com/ppy/osu/pull/22599

beeberies commented 2 days ago

ah, didn't see this at first. thanks!