search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
14.65k stars 2.16k forks source link

Editor timeline break period ignores the Approach circle timing #28703

Open aL1NaZ4R opened 2 days ago

aL1NaZ4R commented 2 days ago

Type

Game behaviour

Bug description

Hi. It's the problem: image image

Also, there is no option to remove the break time.

Screenshots or videos

No response

Version

2024.625.2

Logs

compressed-logs.zip

bdach commented 2 days ago

See https://github.com/ppy/osu/pull/28528

2 beat lengths between the break's end and the first object after break. This is a departure from stable wherein this was ruleset- and AR-dependent (by way of using preempt time), but in talking with the NAT it looked like most didn't know the specifics of how that worked so I decided I'd just use something simpler. This also probably works better for something like mania wherein the "preempt time" is largely user-settings-dependent (scroll speed).

That said there are less than 2 beat lengths on the attached screenshot. Did you change the break's duration manually via the drag handles?

aL1NaZ4R commented 2 days ago

In the screenshot above, yes I did. but the automatic break also overlaps the approach rate.

https://github.com/ppy/osu/assets/89677246/659bcfce-c52a-4653-8dcb-aa1fc47a6e98

aL1NaZ4R commented 2 days ago

I'm not into professional things btw, but I think it would be better to implement stable's one, because with this system, mappers would have to look up those break times again before publishing the map, for ranking issues.

bdach commented 2 days ago

Manually adjusted breaks will not be touched by the automatic generator until a save & reenter. That was intentional.

As for the approach rate thing I dunno. Maybe if I can figure out how to sanely implement it because osu! is by far the easiest case to consider.

aL1NaZ4R commented 2 days ago

As for this one, I didn't touch it. It's exactly after reenter.

2024-07-02_19-20-01.mp4

aL1NaZ4R commented 2 days ago

There will be problems like this, when the distance between two objects is a little high. It DOES overlap the approach circle, and It's NOT removable at all.

https://github.com/ppy/osu/assets/89677246/6b679e37-e501-41df-bd0e-946b610c9a6d

frenzibyte commented 22 hours ago

This is probably not as relevant but since you mentioned "NOT removable at all", technically you can remove them next release with https://github.com/ppy/osu/pull/28707.