Reimplement missing gameplay test hotkeys from stable

ppy / osu

rhythm is just a *click* away!

https://osu.ppy.sh

MIT License

15k stars 2.21k forks source link

Reimplement missing gameplay test hotkeys from stable #28705

Closed bdach closed 2 months ago

bdach commented 2 months ago

Namely:

Tab to toggle autoplay
Ctrl-P to toggle pause
F1 for quick exit at initial position
F2 for exit at current position

There are more that are currently intentionally unimplemented:

Ctrl-B would add bookmarks, but bookmarks are currently completely broken, so that has to get fixed first (https://github.com/ppy/osu/issues/20883)
F3 would change autoplay speed but I think that's weird and I'd rather have something more universal like a rate adjustment control period, regardless of whether autoplay is or is not active. (You could say this also lies within the purview of testing gameplay with selected mods, which is also one thing that people have been asking for.)

frenzibyte commented 2 months ago

osu!catch catcher no longer responds to input after toggling autoplay on then off:

https://github.com/ppy/osu/assets/22781491/d836bf56-dd68-463e-8ace-746df40b49f8
(this one is less severe) on any ruleset, holding a game key then turning on autoplay keeps the key pressed indefinitely, and the autoplay cannot hit any object with that key:

https://github.com/ppy/osu/assets/22781491/d2fd0cc5-e258-4008-960c-e6df4d66ec49

bdach commented 2 months ago

Issues should in theory be fixed although I wouldn't be surprised to see test failures.

frenzibyte commented 2 months ago

Requesting another review mainly for https://github.com/ppy/osu/pull/28705#discussion_r1665036699.

peppy commented 2 months ago

In stable, these hotkeys are explained in a raw text string top-left of test play mode. I'd like to see something similar, but probably better implemented as a tool container in PlayerSettingsOverlay which also allows click/touch access to the various controls.

@bdach any thoughts on this part? I'm fine with getting this in as-is but also don't want the visibility of these keys to be forgotten.

bdach commented 2 months ago

Having these rebindable and show up in the keybinding panel was supposed to be my solution to the issue of discoverability of these, but I guess I don't see any reason not to try and add these back as actual on-screen buttons with a tooltip that shows the relevant key combination I guess.

peppy commented 2 months ago

Yeah I get that they are there, but that likely isn't going to be the first place people look to find hotkeys.

In stable we used to have a help overlay which revealed all the hotkeys that aren't necessarily visible otherwise, maybe that can be something we can explore in the future.

Going to get this in first, regardless.