ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.38k stars 2.29k forks source link

Storyboard positioning is slightly wrong compared to stable #28861

Closed MrHeliX closed 3 months ago

MrHeliX commented 3 months ago

Type

Game behaviour

Bug description

Best shown with an example:

Beatmap: https://osu.ppy.sh/beatmapsets/1790039#osu/3667879 Timestamp: around 18788

Lazer behaviour: osu_2024-07-14_15-48-13

Stable behaviour (expected): screenshot1900

These are two square elements with anchors CentreLeft and CentreRight and both set at position 320,240 (the middle of the screen). The gap that is visible in Lazer should not exist. Storyboard code for these elements:

Sprite,Overlay,CentreRight,"sb\square.png",320,240
 C,0,15112,,0,0,0,213,174,88
 V,0,15112,,0,0,0,10
 V,2,15112,16112,0,10,15,10
 F,0,23445,,1,0
Sprite,Overlay,CentreLeft,"sb\square.png",320,240
 C,0,15112,,0,0,0,213,174,88
 V,0,15112,,0,0,0,10
 V,2,15112,16112,0,10,15,10
 F,0,23445,,1,0

Another example if it helps:

Beatmap: https://osu.ppy.sh/beatmapsets/1485845#osu/3046792 Timestamp: around 107495

Lazer: osu_2024-07-14_15-48-52

Stable: screenshot1899

These are two rectangles sliding from the top and bottom of the screen to meet in the middle. In stable they connect perfectly, in Lazer they leave a gap.

Storyboard code:

Sprite,Overlay,BottomCentre,"sb\square.png",320,-100
 F,0,106468,,0,1
 C,0,106468,,0,0,0,224,74,61
 V,0,106468,,0,0,20,10
 MY,1,106879,107290,-100,240
 F,0,107691,,1,0
Sprite,Overlay,TopCentre,"sb\square.png",320,580
 F,0,106468,,0,1
 C,0,106468,,0,0,0,224,74,61
 V,0,106468,,0,0,20,10
 MY,1,106879,107290,580,240
 F,0,107691,,1,0

I'm playing both Lazer and stable in fullscreen, UI scaling is set at 1 and screen scaling is turned off.

Screenshots or videos

No response

Version

2024.625.2-lazer

Logs

compressed-logs.zip

frenzibyte commented 3 months ago

I am running on 2024.625.2 and I cannot seem to repro any of the issues you brought up. Both examples align just fine on my end, contrary to your screenshots:

https://github.com/user-attachments/assets/181ce0dd-9d0f-489c-8185-60c7668c0a85

cihe13375 commented 3 months ago

I tested on my own pc and it seems that the issue appears only when the "beatmap skins" setting is enabled.

tadatomix commented 3 months ago

I tested on my own pc and it seems that the issue appears only when the "beatmap skins" setting is enabled.

After I tested on MrHeliX's beatmaps, I can agree. For some reason, this setting, quoted above, is messing up bounds of sprites. When, usually, bounds of sprites are scaled notmally, without leaving blurred parts, lazer, for some reason, adds blur to them.

For whatever reason, I was unable to replicate that bug, using lines from MrHeliX code and sprites from those beatmaps. But, after I changed MrHeliX's square sprite to 1x1 white pixel file, problem left and was even more visible.

osu!_EY0WKEekps Here's how sprite looks like in osu!stable. As we can see it's a normal square without any blurry sides

osu!_6K8Vw1xo51 Now here's the same sprite in osu!lazer. Every side is blurry, what makes it lookin more like a star, instead of square.

That's what MrHeliX tried to show. Sprites, like this one, are scaling incorrectly in their beatmaps, leaving those gaps, as we can see in screenshots, presented by them. I dunno why it works only in case with their beatmaps and only when the "beatmap skins" setting is enabled, but truth is truth. This bug actually exists

peppy commented 3 months ago

I tested on my own pc and it seems that the issue appears only when the "beatmap skins" setting is enabled.

Which skin are you using? Did you actually reproduce this without CHANGING storyboard sprites? Because I can't discern that from your reply.

tadatomix commented 3 months ago

I tested on my own pc and it seems that the issue appears only when the "beatmap skins" setting is enabled.

Which skin are you using? Did you actually reproduce this without CHANGING storyboard sprites? Because I can't discern that from your reply.

Okay, my bad for changing sprites. Thought, in that case, issue will be more visible.

Yes, without changing any storyboard sprites, on any skin, this issue is the same as on MrHeliX's screenshots, when you have "Beatmap skins" setting on. So like on the images bellow: osu!_GQt6hbxSL8 Custom legacy skin osu!_NsD9NYXxaz Default legacy skin osu!_CJ1JYskqRF Argon

After you turning off this setting, everything goes back to normal state, like in stable. So like on the images bellow osu!_Zt76gbUI9p Custom legacy skin osu!_LoHKGpses1 Default legacy skin osu!_SnGgNncX2D Argon

tadatomix commented 3 months ago

I think it might somehow be related to the custom skin MrHeliX have on their beatmaps, since, after turning off that setting, everything fixes

tadatomix commented 3 months ago

Also, on frenzibyte's video, this bug isn't shows, since they have "Beatmap skins" setting off, as we can see on this screenshot U8J54se5RN

cihe13375 commented 3 months ago

I tested on my own pc and it seems that the issue appears only when the "beatmap skins" setting is enabled.

Which skin are you using? Did you actually reproduce this without CHANGING storyboard sprites? Because I can't discern that from your reply.

I tested with two maps MrHeliX linked in the first post, without any changes. I tried setting system-wide skin to either argon or a custom skin, and the issue is same as long as the "beatmap skins" setting is enabled. Basically my observation is same as tadatomix's second post (https://github.com/ppy/osu/issues/28861#issuecomment-2230138828)