search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15k stars 2.21k forks source link

Removing the number before comma (,) causes the textbox to reset #29010

Closed aL1NaZ4R closed 2 weeks ago

aL1NaZ4R commented 1 month ago

Type

Game behaviour

Bug description

Hi. If you remove the Number before comma (like in editor or elsewhere), it resets the number instead of ignoring the comma.

https://github.com/user-attachments/assets/e89a52b0-ca6e-45bd-a604-e461d505d151

Screenshots or videos

No response

Version

2024.718.1

Logs

No need

agatemosu commented 1 month ago

,123 should convert to 0,123 instead of the previous value

peppy commented 1 month ago

I'd kinda argue the , shouldn't be in a textbox in the first place 🤔

aL1NaZ4R commented 1 month ago

,123 should convert to 0,123 instead of the previous value

In many other applications, textboxes usually ignore commas and read the numbers only.

peppy commented 2 weeks ago

In many other applications, textboxes usually ignore commas and read the numbers only.

This doesn't work if a european user is entering a decimal number using their local culture (where , is the decimal point).

peppy commented 2 weeks ago

In testing this actually looks to be working how I'd expect it to.