ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15k stars 2.21k forks source link

Visibility and differentiation between beat markers on timeline is not great #29024

Closed aL1NaZ4R closed 1 week ago

aL1NaZ4R commented 1 month ago

Type

Other

Bug description

Hi. Time signature is so useful when sampling hitsounds, but in lazer, they're not that recognizable. Take a look:

image 1/4 is way longer than other beats.

image 1/4 is slightly longer, and thicker than other beats.

and I think it's still so much harder to recognize, compared to stable one. We can make the *other beats* grey, thinner, and shorter to make it easier to recognize.

Screenshots or videos

No response

Version

2024.718.1

Logs

No need

peppy commented 1 month ago

The height difference was drastically reduced recently and I agree it's not great. But consider that you're not comparing 1/4 to 1/4, you're comparing 1/1 to 1/4 (lazer lines are all white, aka 1/1).

We may end up moving the ticks in front of objects again, although will need work on line rendering to make that look good.

bdach commented 1 month ago

The height difference was drastically reduced recently

...to fix the fact that in some situations the tick could be entirely obscured.

Just to make sure this is clearly stated.

peppy commented 1 week ago

Should be resolved via https://github.com/ppy/osu/pull/29545.