search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.54k stars 2.31k forks source link

Issue with osu!catch not holding onto your dashes/movement keys upon restarting #29090

Open Faustas156 opened 4 months ago

Faustas156 commented 4 months ago

Type

Game behaviour

Bug description

video showcases the problem in detail. Shouldn't be incredibly hard to replicate (the Z key is my dash button), sorry for the questionable title, i didn't know how to properly word it out LOL

Screenshots or videos

https://files.catbox.moe/rqdbgx.mp4

Version

2024.726.0-lazer

Logs

compressed-logs.zip

bdach commented 4 months ago

cc @frenzibyte?

frenzibyte commented 4 months ago

Making dashes/movement work when pressing before entering gameplay is fine, but doing so while resuming directly contradicts this very statement that I've been basing all my work, which is to not sync input if it was not pressed before pause. cc @peppy for direction here.

I've got a branch ready for this to handle the "press before entering gameplay" case, but won't PR it until it's discussed how we want to handle this issue in general.

peppy commented 3 months ago

Making dashes/movement work when pressing before entering gameplay is fine, but doing so while resuming directly contradicts https://github.com/ppy/osu/issues/9658#issuecomment-664097922 that I've been basing all my work, which is to not sync input if it was not pressed before pause. cc @peppy for direction here.

Sounds correct. We don't want to allow "pause buffering".