search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.38k stars 2.29k forks source link

Clicking off result panel stops skin's applause sound #29207

Open Drison64 opened 3 months ago

Drison64 commented 3 months ago

Type

Cosmetic

Bug description

When using a legacy skin, the applause sound abruptly stops as soon as the result panel is unexpanded. This issue is especially noticeable with skins that feature longer applause sounds, where the abrupt stop is more pronounced.

Steps to Reproduce

  1. Use a skin with long applause skin.
  2. Complete a map to trigger the results panel.
  3. Expand a different score panel.
  4. Notice the applause sound stops immediately.

Possible Solution

I observed that rankApplauseSound is initialized and triggered within AccuracyCircle, which is only visible when the panel is expanded. A potential fix could be to move the applause sound playback responsibility to ResultsScreen. This change could ensure the sound plays completely, independent of the results panel's visibility.

I am willing to assist in testing and implementing this fix. Please let me know if this proposed solution seems viable, or if further discussion is needed.

Screenshots or videos

https://youtu.be/Nopvg06lZgE

Version

2024.727.0-lazer

Logs

compressed-logs.zip

frenzibyte commented 3 months ago

The playback of the applause sound relies on the introductory accuracy circle animation, which makes it hard to move to ResultsScreen without looking ugly. I would suggest you look into why the sound playback stops playing while expanded, as I would hope the sound should still play so long that the score panel exists on the screen (i.e. as long as the user is in the results screen).