search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.09k stars 2.23k forks source link

Spinner sample point should be at the end time on the timeline #29338

Open OliBomby opened 1 month ago

OliBomby commented 1 month ago

Type

Game behaviour

Bug description

Spinners play their hitsound at the end of the object, so it would make sense if the sample point to edit the hitsound is also at the end of the object on the timeline. With the current behaviour you're forced to navigate to the start of a long spinner in order to change the sound at the end which is a nuisance.

Screenshots or videos

osu!_jvufnmHmrH

Version

2024.731.0-lazer

Logs

compressed-logs.zip

smoogipoo commented 3 weeks ago

See discussion in https://github.com/ppy/osu/pull/29441.

OliBomby commented 3 weeks ago

Why is this closed? In the PR discussion you were all disagreeing about the implementation, but the issue is still there. There was a point made that since it affects spinnerspin it could make sense to have the sample edit at the start, but I don't think spinnerspin is nearly as important as the spinner end sample. 99% of the time a mapper touches that sample edit it will be for the end hitsound. Therefore it should be at the end on the timeline.

smoogipoo commented 3 weeks ago

Sure, that's fair.

bdach commented 3 weeks ago

Honestly I still continue to disagree with the premise of this issue (as I sort of did from the very start) - I think the spinner sample point is completely fine where it is right now.