ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.24k stars 2.27k forks source link

implement replay analysis into spectating #29709

Open Sheppsu opened 1 month ago

Sheppsu commented 1 month ago

Implements the replay analysis overlay into both solo and multiplayer spectating. For multiplayer spectating, the settings container is added on the left side under the leaderboard. For solo spectating it works the same as watching a replay.

Look of the settings container during multiplayer spectating: II4uig8bm6o

Sheppsu commented 1 month ago

Not sure if parsing new frames during each update instead of all at the beginning means the logic in addEntries should be changed to async now, though I haven't had any performance problems running it.

Also now that it's not all parsed at once, would it be better to limit how far ahead it adds entries for? The purpose being to lessen the initial strain for larger replays being viewed in solo.

peppy commented 1 month ago

Please don't do that until it's necessary.

Sheppsu commented 1 month ago

Please don't do that until it's necessary.

Didn't plan to; that's why I'm commenting about it.

Sheppsu commented 3 weeks ago

oops, messed up trying to fix the merge conflict 😓