ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.24k stars 2.27k forks source link

On Windows, file associations aren't registered correctly when updating to Velopack in game #29730

Closed SupDos closed 1 month ago

SupDos commented 1 month ago

Type

Game behaviour

Bug description

When updating from 2024.817.0 to the newest release in game, the file associations seem to still be linked to the previous osu!.exe location.

Originally thought this was only me but someone else on the Discord server had the same issue

Files are registered correctly after running the latest install.exe manually and pressing repair on the popup.

Screenshots or videos

https://github.com/user-attachments/assets/ef2f1c65-6de3-4fde-8605-50216a4b807d

Version

2024.906.1

Logs

compressed-logs.zip Velopack.log

smallketchup82 commented 1 month ago

If you still have the broken installation can you do the following in registry editor: Open HKEY_CURRENT_USER, navigate to Software\Classes, then look for osu.File.osz, then send the value of Shell\Open\Command? This should allow me to confirm what it's set to.

Example: CleanShot 2024-09-06 at 11 31 14@2x

I might have a rough idea as to why this could be happening. I set it so that the associations are only created upon first run, this was under the assumption that we don't need to update associations anymore (since they're just symlinked to current). Seems like I forgot about the situation where people are migrating from squirrel -> velopack.

I'll probably end up having to refactor associations to work well post-velopack (I expect them to be buggy at the moment) anyways, so I'll keep this in mind for then.

For anyone that gets this issue, the fix is as said in the OP, just run the installer again.

SupDos commented 1 month ago

After updating the value in regedit is still "C:\Users\SupDos\AppData\Local\osulazer\app-2024.817.0\osu!.exe" "%1"

smallketchup82 commented 1 month ago

Thanks! I'll try to tackle this (associations refactor) during the weekend.