ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.45k stars 2.3k forks source link

Distance Snapping follows last object beat divisor, hard to work with #30023

Closed rvneXe closed 1 month ago

rvneXe commented 1 month ago

Type

Game behaviour

Bug description

Hi. When I change the beat divisor to common, it doesn't affect distance snapping. Still applies triplets, because the last object (slider end) is using triplets. I know it might be intended, but it's a little annoying.

https://github.com/user-attachments/assets/6f080886-b624-4cfe-b8fd-e5572ab26045

Screenshots or videos

No response

Version

2024.906.2

Logs

no need

bdach commented 1 month ago

I'm not sure what you're expecting to happen here? The previous slider is essentailly unsnapped with that beat divisor.

I think this is a wontfix personally.

cihe13375 commented 1 month ago

I'm not the op poster, but I think at least the timing grids in the playfield and the timeline should be consistent - currently e.g. at 00:09 the note is "snapped to the grid" in the playfield but is not in the timeline. I don't even know how should I interpret this.

Also it breaks in a somewhat different way when the previous object is a circle (grids are shifted by 1/4): 33333

It's not rare that songs have mixed swing and straight beats, and low diffs requires (or benefits from) DS, so I think such scenarios should be supported.

bdach commented 1 month ago

I'm not the op poster, but I think at least the timing grids in the playfield and the timeline should be consistent - currently e.g. at 00:09 the note is "snapped to the grid" in the playfield but is not in the timeline

Sure this is fair, I guess the first ring's radius should be proportionally smaller. If there's anything to fix here it'd be that.

rvneXe commented 1 month ago

I'm not sure what you're expecting to happen here? The previous slider is essentailly unsnapped with that beat divisor.

That slider end is snapped by Triplet divisor, 1/6 I've changed the divisor to common, and I want to place a hit object on 1/2 beat division (Common) But it still snaps it by triplet divisions.