search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.54k stars 2.31k forks source link

The "Edit externally" button in the editor is in English regardless of the selected language. #30567

Closed MrCatGitHub closed 3 weeks ago

MrCatGitHub commented 3 weeks ago

Type

Cosmetic

Bug description

In the editor, the "Edit externally" button is in English rather than the language osu! is set to.

Screenshots or videos

german japanese

Version

2024.1009.1-lazer

Logs

compressed-logs.zip

Joehuu commented 3 weeks ago

There are many other strings hardcoded/unlocalisable, like the right side of editor, and that it's not strictly enforced for new strings, so closing for those reasons.

If you want, you can follow https://github.com/ppy/osu/wiki/Localising-the-client#localising-hardcoded-strings and make a pull request for the specified string you mentioned and possibly more that you can find.

As for a hint, I would put that string and other editor strings in https://github.com/ppy/osu/blob/master/osu.Game/Localisation/EditorStrings.cs.