ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.42k stars 2.29k forks source link

Velopack crashed on update #30645

Open necocat0918 opened 3 hours ago

necocat0918 commented 3 hours ago

Type

Other

Bug description

I was in the last version of lazer, and once the update is downloaded, velopack showed a window about lazer is being updated, but velopack crashed because it can't find some components

Screenshots or videos

the "current" folder is gone image

Version

2024.1009.1 ~ 2024.1115.1

Logs

Velopack.log

smoogipoo commented 2 hours ago

but velopack crashed because it can't find some components

What happened more exactly? Did you get a standard Windows crash log? If so, maybe try checking for any errors in the event viewer (https://docs.microsoft.com/en-us/host-integration-server/core/how-to-check-the-windows-event-logs-for-errors1).

There's these ominous lines in the log:

[update:14164] [20:29:11] [WARN] Failed to locate app manifest (This application is missing a package manifest (.nuspec) or it could not be parsed.), trying legacy package resolution...
[update:14164] [20:29:11] [INFO] Attempting to auto-detect package in: C:\Users\necos\AppData\Local\osulazer\packages
[update:14164] [20:29:13] [INFO] Found 2024.1115.1: 'C:\Users\necos\AppData\Local\osulazer\packages\osulazer-2024.1115.1-full.nupkg'
[update:14164] [20:29:13] [INFO] Found full package to read: C:\Users\necos\AppData\Local\osulazer\packages\osulazer-2024.1115.1-full.nupkg
[update:14164] [20:29:13] [ERROR] Start error: Unable to find executable to start: '"C:\\Users\\necos\\AppData\\Local\\osulazer\\current\\osu!.exe"'

But apart from that last one I'm not sure if they're relevant. We're definitely packing a nuspec (well... Velopack does that itself):

image

Can you start the game fine a second time?

Maybe cc @caesay

necocat0918 commented 2 hours ago

There's these ominous lines in the log

the package file does exist, the current folder is gone so the app won't run

Can you start the game fine a second time?

no, neither the updater nor the osu!.exe in the root folder will run

Maybe cc @caesay

https://github.com/velopack/velopack/issues/355 is this the issue that cause this situation?

bdach commented 1 hour ago

is this the issue that cause this situation?

no. that issue is a linux issue. you are not on linux.

caesay commented 1 hour ago

Update.exe process appears to have crashed during the update.

The last log printed was "Backing up current dir to C:\Users\necos\AppData\Local\osulazer\packages\VelopackTemp\tmp_7zRRNYZ8Kx06lNHE" - and then nothing.

What's weird is that this binary is written in Rust, so there shouldn't really be unhandled crashes (without log messages) in general.

smoogipoo commented 10 minutes ago

@necocat0918 please check if there's an error in event viewer.