Leaving a multiplayer lobby now plays the "host leaving" sound

[diediediebitch]

Type

Game behaviour

Bug description

When you leave a multiplayer lobby it will play the sound of the host in your lobby leaving as well as the original leave game sound

I'm assuming this isn't intended and I checked the changelog and it wasn't mentioned

Screenshots or videos

No response

Version

2024.1115.2

Logs

compressed-logs.zip

[peppy]

@smoogipoo likely one for you

[smoogipoo]

The fix appears to be something along the lines of:

diff --git a/osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerRoomSounds.cs b/osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerRoomSounds.cs
index d53e485c86..5da6e0a19d 100644
--- a/osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerRoomSounds.cs
+++ b/osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerRoomSounds.cs
@@ -50,7 +50,7 @@ private void updateState()
                 return;

             // only play sound when the host changes from an already-existing host.
-            if (host != null)
+            if (host != null && client.Room?.Host != null)
                 Scheduler.AddOnce(() => hostChangedSample?.Play());

             host = client.Room?.Host;

Though I'm not sure about committing this now or after https://github.com/ppy/osu/pull/30634 .