ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.49k stars 2.3k forks source link

No osu! icon on Linux. #30810

Closed DarkGradient closed 1 day ago

DarkGradient commented 1 day ago

Type

Cosmetic

Bug description

Fix osu!.desktop file: corrected Version and SingleMainWindow keys

What Lines Changed

X-SingleMainWindow=true Version=1.0

This should fix osu!.Appimage icon for Linux Srry, i don't know how to use pull requests :(

Screenshots or videos

image Before --> After

Version

Latest

Logs

Runned command: ./appimagetool-x86_64.AppImage osu-root/ Output: /home/hertz/not_error/AppImages/osu-root/osu!.desktop: error: value "1.5" for key "Version" in group "Desktop Entry" is not a known version

/home/hertz/not_error/AppImages/osu-root/osu!.desktop: error: file contains key "SingleMainWindow" in group "Desktop Entry", but keys extending the format should start with "X-"

This happens before fix. And i think this is a reason of missing icon on Linux.

bdach commented 1 day ago

30759