search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.32k stars 2.28k forks source link

Applaud samples won't shut up #3831

Closed chayleaf closed 1 year ago

chayleaf commented 5 years ago

Happens here: https://osu.ppy.sh/beatmapsets/139525/#taiko/361158

Once applauds start, they don't stop for like 30 seconds

holly-hacker commented 5 years ago

Seems to be 2 issues:

  1. Lazer doesn't look for taiko- prefixes on hitsound samples
  2. Lazer will try to always load custom samples, even if CustomSampleBank is 0

I can't seem to find a way to fix 2, since SampleControlPoint is completely decoupled from LocalSkinOverrideContainer, where I believe the ISkinSource is decided.

EDIT: for the record, the problem is that a custom sample is loaded when it shouldn't.

peppy commented 1 year ago

I know this is a very old one, but I can't reproduce the issue anymore. So it's probably fixed? @holly-hacker are you able to confirm?

holly-hacker commented 1 year ago

Considering this was reported 4 years ago, it is likely already solved. I will try to reproduce when I get home in about 7 hours.

holly-hacker commented 1 year ago

I compared lazer's behavior (2022.1228.0) to stable's (20230101.2) using autoplay and the issue still seems to exist.

In lazer, on each large red note (and possibly some blue notes, I'm not too familiar with hitsamples in taiko) the applause/normal-hitfinish sample plays for about 5 seconds before fading out quite quickly. I'm not sure how this was supposed to last 30s considering the sample file is only 5s long. Presumably OP thought it kept on playing since it gets started multiple times. In stable, there is no applause sound at all. I tried various combinations of skin settings but I always heard just the default hitsounds.

peppy commented 1 year ago

At what point do you hear the sound?

holly-hacker commented 1 year ago

https://user-images.githubusercontent.com/13605369/212306248-81ead849-ae14-4e47-bd47-6b8ed05eb458.mp4

It happens at every large red note, see attached video.

Since you don't seem to be able to repro this, I removed the map and downloaded it again. With a fresh import of the beatmap, it doesn't seem to happen anymore. I assume this is an old bug wrt importing beatmaps that has since been fixed?

peppy commented 1 year ago

That is likely it. If that's the case, let's close this one as that's not going to be feasible to fix.