search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.4k stars 2.29k forks source link

Autoplay causes circle/slider rendering to pause for one frame when it clicks #4587

Open Morodar opened 5 years ago

Morodar commented 5 years ago

Describe the bug: I've noticed a little stutter in Autoplay whenever a circle is hit or the end of a slider is reached.

Screenshots or videos showing encountered issue: So I've recorded my monitor at 480 FPS. The monitor's (and osu!lazers) framerate is at stable 165 FPS. The YouTube Video displays it at 30 FPS. So every third frame in the video equals one frame in osu!lazer.

(You can go back and forward one frame in YouTube with ',' and . key.) https://www.youtube.com/watch?v=vzVGDL7DXxc&t=42

The score is always updated every third frame. However, the approach circle is not updated every third frame when autoplay clicks a circle or reaches end of a slider.

This can specially be noticed in streams.

osu!lazer version: 2019.402.0

Logs: None

peppy commented 5 years ago

This is due to important section handling, and currently intentional (see the frame accurate flag in rulesetinputmanager. There's definitely room for improvement here but we are preferring correctness for now.