search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.34k stars 2.28k forks source link

Add back comboburst #4629

Open KirbyJoe opened 5 years ago

KirbyJoe commented 5 years ago

Describe the missing feature: Comboburst is described on the glossary like this:

A comboburst is a celebration of achieving a combo milestone.

The visual effect is missing on osu!lazer.

mk56-spn commented 2 years ago

Idk. Is this really a necessary thing ? Maybe for legacy's sake but I doubt it'll be prioritized

mk56-spn commented 2 years ago

Idk. Is this really a necessary thing ? Maybe for legacy's sake but I doubt it'll be prioritized

This can be necessary, to cheer people for getting a milestone after making a chain combo. If you just, go to osu!, click the circles only, without encouragement from the skin they choose, then players can easily get upset when they are trying to pass a hard map. Not the most priority stuff, but at least, it's needed for osu! traditions too. And like I mentioned in #16578 , there should be a button to turn off the combo-burst if people don't want to see it.

Understandable I guess. Keep in mind combo will likely become a lot less meaningful with the upcoming combo scaling removal rework from PP. Which effectively makes holding combo devoid of any value. But yeah thisll probs get added when skinning gets done

Cookiesmuch commented 1 year ago

Sorry if this counts as ghost-posting, however I would like to say that if someone made the code for the Stable! Combo burst publically available, so that someone (even an unaffiliated contributor) may quickly add it to Lazer. As far as I'm aware, this is how the Smoke was added to Lazer as well.

SysError99 commented 7 months ago

In my humble opinion, unless the combo burst is really something that's only specific to certain rulesets, this deserves more consideration on a proper API for other rulesets too.