Music player should listen to common keyboard actions

ppy / osu

rhythm is just a *click* away!

https://osu.ppy.sh

MIT License

15.55k stars 2.31k forks source link

Music player should listen to common keyboard actions #5918

Open luaneko opened 5 years ago

luaneko commented 5 years ago

Describe the bug: Music player does not listen to common keyboard actions.

Some common keys are (off the top of my head):

Space for pause/resume
Arrows for seeking (with usually a modifier to seek quicker)
Arrows with CTRL to play the next/previous track
Possibly another shortcut to toggle the playlist overlay

If this is not feasible, we should at least describe somewhere that you can use the function keys to control the player.

Screenshots or videos showing encountered issue: none

osu!lazer version: 2019.830.0

Logs: irrelevant

aspriddell commented 5 years ago

It'd be really good if it could respond to native keys, eg f8 to play/pause on a Mac keyboard or f10 on HP devices. For this I think it would have to register with the OS as a music player/playback system, a bit like how Spotify, iTunes and (now) Chrome does.

frenzibyte commented 5 years ago

It'd be really good if it could respond to native keys, eg f8 to play/pause on a Mac keyboard or f10 on HP devices. For this I think it would have to register with the OS as a music player/playback system, a bit like how Spotify, iTunes and (now) Chrome does.

You mean media keys? it's already supported like that

aspriddell commented 5 years ago

In that case, a playlist toggle and seek ones would be useful, as play pause is already added (to some extent). Also I don’t think it provides the os with any info about the current track: I know this isn’t in the scope of osu! but I’m sure some people use it as a music player so it could put next to the volume slider triggered by function keys what the song name and artist is

yuuiko commented 5 years ago

I don’t think osu music controls are setup for mac yet. Media keys don’t seem to work here and osu does not appear in the system now playing interface.

Also our media keys are not f8, they are media keys.

Would be nice if this was implemented.

peppy commented 5 years ago

If you mean media keys when the window is not focused: we have no intention of doing this.

If you mean while it is focused, the defaults may be wrong but you can re-bind them.