ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.38k stars 2.29k forks source link

Delete key does not work in search textboxes #6944

Open luaneko opened 4 years ago

luaneko commented 4 years ago

Describe the bug:

Delete key (not backspace) does not work in the direct overlay's search textbox. However, it works with Ctrl modifier pressed, and deletes the entire word as expected.

I believe this is a bug with SearchableListFilterControl because beatmap selection search produces the same behavior.

Screenshots or videos showing encountered issue:

https://streamable.com/clmiz

Delete key was pressed 10 times in this video.

osu!lazer version: 2019.1122.0

Logs: runtime.log

bdach commented 4 years ago

Looks like it's explicitly suppressed here:

https://github.com/ppy/osu/blob/f43e4bfd703d4cd3a9f747a7ead88ac4e690f08c/osu.Game/Graphics/UserInterface/SearchTextBox.cs#L37-L41

(see framework-side GlobalAction mapping)