search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.07k stars 2.23k forks source link

Multiple spin rate counters visible for consecutive spinners #7023

Closed Squiddu closed 3 years ago

Squiddu commented 4 years ago

(This isn't really a BUG, just a visual that looks off.)

Describe the bug: When a beatmap has multiple spinners next to each other, the SPM (Spins Per Minute) counter on the next spinner starts to appear.

Screenshots or videos showing encountered issue: osu_2019-11-30_14-48-32

osu!lazer version: 2019.1128.0

Logs: As this is not technically a bug, no logs can be found.

LastExceed commented 4 years ago

Is this for overlapping or consecutive spinners? If overlapping then I'd say its fine like this but if consecutive then we should try to prevent this

bdach commented 4 years ago

I don't really think it even matters myself, shouldn't show up twice even if overlapping.

peppy commented 4 years ago

The timing of the display should probably be altered to avoid this. Alternatively we decide to move the SPM counter to be part of the HUD, and have it displayed as a singleton, but this would require some thinking and careful consideration (ie. are there going to be other such counters going forward, to the point it requires this?)

smoogipoo commented 4 years ago

Doesn't need to be part of the HUD, can be part of OsuPlayfield.

peppy commented 4 years ago

Let's keep it at the spinner level.

smoogipoo commented 4 years ago

please suggest how to solve this issue if you keep it at the spinner level.

peppy commented 4 years ago

As above, the timings should be changed to avoid overlap for now, if this is an issue in ranked beatmaps.

frenzibyte commented 3 years ago

This looks to be improved with https://github.com/ppy/osu/pull/11626, as SPM displays now appear only at the spinner's "hittable" time, not sure whether should be closed though.

peppy commented 3 years ago

@frenzibyte for reference, which beatmap are you testing with? i can't seem to find a reference to the one used in the OP here.

frenzibyte commented 3 years ago

Just brought up that given that the issue title is talking about consecutive spinners, not sure what the beatmap the OP was using here, and whether the spinners are consecutive or overlapping each other for their case.

peppy commented 3 years ago

So you haven't visually tested this? Generally if you say "looks to have improved", you would have checked it using something, so I was wanting to know how/where you confirmed this.

frenzibyte commented 3 years ago

Ah, I see. My bad with the choice of words there.

peppy commented 3 years ago

@Squiddu (or anyone else) could you please link the beatmap you were seeing this issue with?

Joehuu commented 3 years ago

OP beatmap is https://osu.ppy.sh/beatmapsets/413117#osu/1036170 (Hard diff) at same spot 23%. Seems to be fixed, so closing.

https://user-images.githubusercontent.com/35318437/110423593-32a2b980-8056-11eb-97a6-037039f4b474.mp4