search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.38k stars 2.29k forks source link

Seasonal backgrounds #7055

Closed X4X5 closed 4 years ago

X4X5 commented 4 years ago

Describe the new feature: It would be exactly like Stable in the sense that with every season, you can enable seasonal backgrounds instead of the default background when you open Lazer. Different from Stable, however, each picture would be present for, lets say 10 seconds, then it changes to a new picture. So it basically constantly refreshes the pictures instead of staying on just one picture.

Proposal designs of the feature: Button under skinning? Maintenance? Since I have a Chromebook, I can't go back to the Stable client to remember where that button was on that client to know where to put it in Lazer.

MightyHelper commented 4 years ago

Maybe change when the song changes? Sometimes they have a lot of detail and I like to look at them for a while.

peppy commented 4 years ago

This can be added in the menu background dropdown. It should be implemented to pull from an online API source, and load the backgrounds as required. It would change once on song change or resuming as per the existing implementation.

mcendu commented 4 years ago

Are there any machine readable index (i.e. not the news posts) of art contests and winners, so that I can access them from assets.ppy.sh/contests/[name your id]/winners/[name your background]?

peppy commented 4 years ago

An API endpoint would need to be made for this. I believe we already have stuff databased so it should not be a huge effort required.

Wieku commented 4 years ago

I thought there is an endpoint already because osu!stable downloads them when needed. Or was it added during this season?

peppy commented 4 years ago

The endpoint is in API v1, which should probably not be used in lazer. We can eventually add it to osu-web.

mcendu commented 4 years ago

Should we move it to candidate (or just un-backlog this)?

frenzibyte commented 4 years ago

Should we move it to candidate (or just un-backlog this)?

From what i've seen, Backlog milestone goes for issues / features that don't need to be resolved at the moment and may require huge effort to resolve, you can check the Candidate Issues and other milestones and compare with them to understand which is more important.

smoogipoo commented 4 years ago

A v2 endpoint for this has been PR'd. You can code against the specification provided there: https://github.com/ppy/osu-web/pull/5506, route: seasonal-backgrounds

hbnrmx commented 4 years ago

Would like to give this a shot, while the Halloween event is still running.

Currently https://osu.ppy.sh/api/v2/seasonal-backgrounds is returning {} so I'm assuming SEASONAL_CONTEST_ID env var is not set.

if it's not too much work, could you set it for testing purposes? Thank you.

peppy commented 4 years ago

is set now