pq-code-package / mlkem-native

High-assurance, high-performance ML-KEM implementation for mobile, pc, and server targets
https://pq-code-package.github.io/mlkem-native/dev/bench/
Apache License 2.0
11 stars 9 forks source link

Fix tests bench --opt=all and tests all --no-acvp #398

Open potsrevennil opened 1 week ago

potsrevennil commented 1 week ago
potsrevennil commented 1 week ago

@hanno-becker Done

hanno-becker commented 1 week ago

407 cherry-picks first commit.

potsrevennil commented 1 week ago

I tried to make the git diff looked friendlier, hope that it'd be clear that this was just a simple rewrite, which is just merging the conditional compile and run_schemes local functions (ex: _func in func) into a general function Test_Implementation.test to avoid similar mistake fixed in the first commit

hanno-becker commented 1 week ago

@potsrevennil I seem to remember there a different diff options locally at least... anyone in particular that will make it more obvious what is happening?

potsrevennil commented 1 week ago

@hanno-becker thanks for the comment! I removed one indirection, I think the indirections should be the same as before now. And as I commented, once we have a build system that can separate opt/non-opt built artifacts, we could further reduce indriections, to make the tests script more readible.

hanno-becker commented 1 week ago

@potsrevennil Thank you for the explanations, which I am still to read closely. On first though, we now have self.func, self._func and self.__func, which really can't be it, I feel.

potsrevennil commented 4 days ago

@hanno-becker sorry, the naming was pretty bad, I updated it now