Create mlkem-c-aarch64 ACLs

pq-code-package / tsc

PQ Code Project Technical Steering Committee resources

https://pq-code-package.github.io/tsc/

Creative Commons Attribution 4.0 International

4 stars 4 forks source link

Create mlkem-c-aarch64 ACLs #38

Closed ryjones closed 6 months ago

ryjones commented 6 months ago

resolves #37

clowarden[bot] commented 6 months ago

Validation succeeded

✅ The proposed configuration changes are valid!

Configuration changes

Directory

team pqcp-embedded-maintainers-aarch64 has been added
- Maintainers
  - mkannwischer
- Members
  - cothan
    Github
repository mlkem-c-aarch64 has been added (visibility: public)
- Teams
  - pqcp-embedded-admin: admin
  - pqcp-embedded-maintainers-aarch64: maintain
  - pqcp-embedded: read
  - pqcp-embedded-maintainers: maintain

🔸 Please review the changes detected as they will be applied immediately once this PR is merged 🔸

ryjones commented 6 months ago

@cothan

cothan commented 6 months ago

Thanks @ryjones, according to our plan, I will make sure the intrinsic version of MLKEM-c-aarch64land first, then the assembly when @mkannwischer finish with the mlkem-c-embedded project.

cothan commented 6 months ago

I don't know if it's okay, I also want to be the maintainer of this repo.

ryjones commented 6 months ago

@cothan you are a member of the team which has maintain access to the repo. maintainer, in the context of a team, means you can maintain the team, not the repo itself.

cothan commented 6 months ago

@ryjones Thanks for the clarification. A member is all I need.

planetf1 commented 6 months ago

Great we have any variant ! @ryjones Can I check the intent of the team definition...

We have a new team pqcp-embedded-maintainers-aarch64 which adds an additional maintainer for this repo (@cothan ), but otherwise uses the same permissions as the embedded repo.

The two implementations are closely related, with similar maintainers - I presume this is why?

ryjones commented 6 months ago

@planetf1 yes. unless @mkannwischer wants to have one team with all the same permissions, or this repo should be added to another team, or something.

planetf1 commented 6 months ago

One may be easier, but given the time difference I'm fine we merge anyway to help @cothan get started

clowarden[bot] commented 6 months ago

Reconciliation completed

✅ The reconciliation completed successfully and all changes have been applied across the services!

Changes applied

Github

team pqcp-embedded-maintainers-aarch64 has been added
- Maintainers
  - mkannwischer
- Members
  - cothan
team pqcp-embedded has been added to repository mlkem-c-aarch64 (role: read)
team pqcp-embedded-maintainers has been added to repository mlkem-c-aarch64 (role: maintain)
team pqcp-embedded-maintainers-aarch64 has been added to repository mlkem-c-aarch64 (role: maintain)
team pqcp-embedded-admin has been added to repository mlkem-c-aarch64 (role: admin)

cothan commented 6 months ago

Hi @ryjones, I don't have write permission to push commits, I'm not sure what I did wrong, can you double-check that I have write permission?

cothan commented 6 months ago

Oh, nevermind. I forget to accept the invitation.