search

pq-crystals / dilithium

Other
375 stars 139 forks source link

Fix out-of-bounds reads #33

Closed thomwiggers closed 3 years ago

thomwiggers commented 4 years ago

These reads might not have been acted upon, but it's still not allowed to just dereference pointers past the bounds of an array.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 94.537% when pulling d21bc0ec842e5565e6b7614ffe1fc0dc254d2043 on thomwiggers:fix-access-out-of-bounds into 497a98bc7efe48cb0d18fd20d6d9a4b5629406ef on pq-crystals:master.

gregorseiler commented 3 years ago

The buffers for rej_uniform_avx have the additional 8 bytes in the round 3 code now and there is no gamma1 rejection sampling anymore.