search

pq-crystals / dilithium

Other
374 stars 136 forks source link

dilithium/ref/poly.c:868 maybe not correct? #63

Open ffox9527 opened 2 years ago

ffox9527 commented 2 years ago

now is r->coeffs[2*i+0] &= 0xFFFFF; maybe r->coeffs[2*i+1] &= 0xFFFFF; not sure, pls check, thx!

ffox9527 commented 2 years ago

The line should be superfluous, r->coeffs[2i+0] has been AND with 0xFFFFF, and r->coeffs[2i+1] only has 20 bits, no need to AND with 0xFFFFF.