search

pq-crystals / dilithium

Other
374 stars 136 forks source link

Possibly wrong macro TRBYTES in crypto_sign_verify standard branch #75

Closed marco-palumbi closed 1 year ago

marco-palumbi commented 1 year ago

CRHBYTES macro should be used instead of TRBYTES in: https://github.com/pq-crystals/dilithium/blob/e29d6eff0319baa14b9ec91d3bd6d912d294951d/ref/sign.c#L255 and: https://github.com/pq-crystals/dilithium/blob/e29d6eff0319baa14b9ec91d3bd6d912d294951d/ref/sign.c#L257

cryptojedi commented 1 year ago

Indeed, thank you very much for pointing this out!