ML-KEM: functions that use buffers on the stack

pqc-thunderbird / libgcrypt

GNU General Public License v2.0

1 stars 0 forks source link

ML-KEM: functions that use buffers on the stack #38

Closed falko-strenzke closed 11 months ago

falko-strenzke commented 11 months ago

from Jussi's review:

There's many functions that use buffers on stack. Do those contain secrets? Should those buffers be wiped before returning from function (with wipememory())? For example, "mlkem_check_secret_key" has two buffers "shared_secret_1" and "shared_secret_2" which are not wiped.