The code shown in the figure below from us in pgp-key.cpp should be refactored. It is not good style to have the function return the value directly in the switch-case statements in general and return it for the EC-schemes at the end of the function outside the switch-case statment. Rather, the result for the EC-schemes should be returned (after fallthrough) in the last of the EC labels.
The code shown in the figure below from us in pgp-key.cpp should be refactored. It is not good style to have the function return the value directly in the switch-case statements in general and return it for the EC-schemes at the end of the function outside the switch-case statment. Rather, the result for the EC-schemes should be returned (after fallthrough) in the last of the EC labels.