search

pqc-thunderbird / rnp

Manual clone of the repository https://github.com/rnpgp/rnp
Other
0 stars 0 forks source link

v6 keyid is calculated incorrectly. #41

Closed ni4 closed 11 months ago

ni4 commented 1 year ago

Description

As of section 5.5.4.3 from crypto-refresh draft, "The Key ID is the high-order 64 bits of the fingerprint.", while code in tb-pqc uses v4 approach (low-order bits).

ni4 commented 1 year ago

...this is also apply to the method pgp_signature_t::keyid()

TJ-91 commented 1 year ago

That's correct, we missed that. pgp_keyid() in fingerprint.cpp seems to do the same calculation. Changing those two places should be enough, right?

ni4 commented 1 year ago

@TJ-91 Yeah, I think so. I already implemented this in v5 draft PR here: https://github.com/rnpgp/rnp/pull/2111 , so you may take a look there.

TJ-91 commented 1 year ago

This should be correctly implemented now. I aligned this to your code and should be easy to merge

falko-strenzke commented 1 year ago

@TJ-91 Can we close this now?

TJ-91 commented 11 months ago

yes