search

pqc-thunderbird / rnp

Manual clone of the repository https://github.com/rnpgp/rnp
Other
0 stars 0 forks source link

ec_curves.cpp: values for Ed448/X448 #91

Closed TJ-91 closed 3 weeks ago

TJ-91 commented 3 weeks ago

@ni4 currently I only have some dummy values in the ec_curves array for Ed448/X448. I'm not sure how to fill out the fields. Can you tell me what to do here? After fixing this, I would like to make a new PR with the Crypto Refresh and PQC changes.

https://github.com/pqc-thunderbird/rnp/blob/fb629fd00a53b4233573b3a79d41bf6bdfbdc2e5/src/lib/crypto/ec_curves.cpp#L266-L296

ni4 commented 3 weeks ago

@TJ-91 while number fields could be omited, botan_name field should be borrowed from Botan's sources ("Ed448") : Ed448 , as well as number of bits. ASN.1 encoding could be borrowed from librepgp specification: https://datatracker.ietf.org/doc/draft-koch-librepgp/ (section 9.2.).

TJ-91 commented 3 weeks ago

Thanks a lot!