Implement Buffering for Signed Cleartext Messages (for v6 salt)

pqc-thunderbird / rnp

Manual clone of the repository https://github.com/rnpgp/rnp

Other

0 stars 0 forks source link

Implement Buffering for Signed Cleartext Messages (for v6 salt) #92

Closed TJ-91 closed 2 weeks ago

TJ-91 commented 3 weeks ago

A solution for processing v6 cleartext signatures is buffering the message. Then the salt and hash can be initialized, and the buffer will be hashed.

Determine a sensible maximum buffer size
Implement the buffering (if Crypto Refresh enabled)
In parallel the currently implemented processing is still useful in case of processing a non-salted message that is larger than the buffer

@ni4 is that something you would consider if we implement it?

ni4 commented 2 weeks ago

@TJ-91 crypto-refresh ifdefs (or, better say, standard itself) and new code paths already made things complicated, and within these changes they would get complicated even more. Do we have a real need for that, given that crypto-refresh discourages usage of clear-text signing?

TJ-91 commented 2 weeks ago

Alright, I'll close this issue then