pqienso / pe

0 stars 0 forks source link

DG sequence diagram: activation bar #15

Open pqienso opened 3 months ago

pqienso commented 3 months ago

Seen on page 10 of DG. Screenshot 2024-04-19 173557.png Should the newly created MealList, DrinkList and ExerciseList objects return to :User as myMealList, myDrinkList and myExerciseList respectively? Afterwards, shuold their activation bars be deactivated? The activation bars for these 3 objects span the entire sequence diagram, which should not be the case as their methods are not continuously being used throughout handleViewXYZ().

nus-pe-script commented 3 months ago

Team's Response

The activation bars were not deactivated as the sequence diagram shown was only used to display the interaction for the method where the user would like to view the nutritional content (as mentioned in the DG). Thus, the objects of mealList, drinkList and exerciseList had not been deleted in this case (should only be deleted when exit is called)

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

[x] I disagree

Reason for disagreement: My issue raised was not about the objects not being deleted, but rather, their activation bars being too long as they should exist but not be active for some parts of the diagram.

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]